chore(api-core): restore fail_under=100 in .coveragerc#17768
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the coverage configuration in .coveragerc for packages/google-api-core. Specifically, it increases the minimum coverage threshold (fail_under) from 99% to 100% and configures the coverage report to omit test directories (tests/* and /tests/). There are no review comments to address, and I have no additional feedback to provide.
…d protobuf version branches
…ansport instance and add --fail-under=100 to cover session in noxfile
…st_operations_client.py
…nt.py for protobuf version branches
parthea
approved these changes
Jul 20, 2026
hebaalazzeh
pushed a commit
that referenced
this pull request
Jul 20, 2026
`fail_under` was previously adjusted down to `99` because coverage reports included helper lines inside test files (`tests/unit/test_operations_rest_client.py`). In non-`async_rest` matrix sessions, conditional `if GOOGLE_AUTH_AIO_INSTALLED:` checks inside test runner files were flagged as un-executed lines, artificially dragging down total reported coverage. - Configured `omit = tests/*, */tests/*` under `[report]` in `.coveragerc` so coverage reporting evaluates threshold enforcement (`fail_under`) strictly against the `google.api_core` source library rather than test execution helper code. - Restored `fail_under = 100` in `.coveragerc`. Towards #17459 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fail_underwas previously adjusted down to99because coverage reports included helper lines inside test files (tests/unit/test_operations_rest_client.py). In non-async_restmatrix sessions, conditionalif GOOGLE_AUTH_AIO_INSTALLED:checks inside test runner files were flagged as un-executed lines, artificially dragging down total reported coverage.omit = tests/*, */tests/*under[report]in.coveragercso coverage reporting evaluates threshold enforcement (fail_under) strictly against thegoogle.api_coresource library rather than test execution helper code.fail_under = 100in.coveragerc.Towards Move back to 100% coverage standard #17459 🦕