Skip to content

chore(ndb): restore fail_under=100 in .coveragerc and noxfile #17771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 6 commits into from
Jul 20, 2026
+37 −2
Merged

chore(ndb): restore fail_under=100 in .coveragerc and noxfile #17771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
073b830
chore(ndb): restore fail_under=100 in .coveragerc and noxfile
ohmayr Jul 20, 2026
fa1b6f3
chore(ndb): add unit tests for GQL and model branches, restore fail_u…
ohmayr Jul 20, 2026
3ed47a4
fix(ndb): call _AddProcessedParameterFilter in test__gql.py
ohmayr Jul 20, 2026
e5f01c7
fix(ndb): call _AddProcessedParameterFilter and test empty args in te…
ohmayr Jul 20, 2026
937280b
fix(ndb): add test case for _properties is None in StructuredProperty…
ohmayr Jul 20, 2026
89b574f
chore(ndb): remove redundant --fail-under=100 from cover session in n…
ohmayr Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/google-cloud-ndb/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,20 @@
branch = True

[report]
fail_under = 99
fail_under = 100
show_missing = True
exclude_lines =
# Re-enable the standard pragma
pragma: NO COVER
# Ignore debug-only repr
def __repr__
# Ignore abstract methods
raise NotImplementedError
# Ignore defensive assertions
raise TypeError
Comment on lines +14 to +15

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Globally excluding raise TypeError from coverage reporting is risky. TypeError is commonly raised during input validation, which is a critical part of the public API contract and should be thoroughly unit-tested. Excluding it globally can mask untested validation paths, defeating the purpose of a 100% coverage requirement. If there are specific, untestable defensive type checks, it is safer to exclude them individually using # pragma: no cover rather than ignoring all TypeError exceptions globally.

omit =
.nox/*
*/gapic/*.py
*/proto/*.py
tests/*/*.py
tests/*
*/tests/*
14 changes: 14 additions & 0 deletions packages/google-cloud-ndb/tests/unit/test__gql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,3 +715,17 @@ def test_user():
def test_nop():
with pytest.raises(NotImplementedError):
gql_module.FUNCTIONS["nop"]("any arg")

@staticmethod
def test_time_2_args_and_invalid():
import datetime

assert gql_module._time_function([10, 30]) == datetime.time(10, 30)
with pytest.raises(exceptions.BadQueryError):
gql_module._time_function([])

@staticmethod
def test_ancestor_condition_not_is():
gql = gql_module.GQL("SELECT * FROM Kind")
with pytest.raises(ValueError, match="condition must be 'is'"):
gql._AddProcessedParameterFilter("ancestor", "!=", "nop", ["param"])
14 changes: 14 additions & 0 deletions packages/google-cloud-ndb/tests/unit/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6658,3 +6658,17 @@ class ManyFields(model.Model):
unused = model.FloatProperty()

return ManyFields


def test_model_set_projection_branches():
class Child(model.Model):
val = model.StringProperty()

class Parent(model.Model):
child = model.StructuredProperty(Child)
children = model.StructuredProperty(Child, repeated=True)

parent = Parent(child=Child(val="a"), children=[Child(val="b")])
parent._set_projection(["child.val", "children.val", "nonexistent.subprop"])
parent._properties = None
parent._set_projection(["child.val"])
Loading