impl(bigquery): generate job/request IDs and mark query RPCs idempotent - #6219
Open
alvarowolfx wants to merge 2 commits into
Open
impl(bigquery): generate job/request IDs and mark query RPCs idempotent#6219alvarowolfx wants to merge 2 commits into
alvarowolfx wants to merge 2 commits into
Conversation
product-auto-label
Bot
added
the
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces unique ID generation for BigQuery jobs and query requests using UUIDs to enable request idempotency. It updates the execution paths to set idempotency options and adds corresponding unit tests. The review feedback suggests refactoring generate_job_reference into an associated function to avoid borrowing &self and eliminate an unnecessary clone of project_id, which also simplifies its unit test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6219 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 269 269
Lines 67282 67330 +48
=======================================
+ Hits 64606 64654 +48
Misses 2676 2676 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alvarowolfx
marked this pull request as ready for review
July 30, 2026 14:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #5844 #6218