Skip to content

feat(storage): add code samples - #6225

Open
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_6
Open

feat(storage): add code samples#6225
vsharonlynn wants to merge 2 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_6

Conversation

@vsharonlynn

Copy link
Copy Markdown
Contributor

Issue #5716.

@vsharonlynn
vsharonlynn requested a review from joshuatants July 30, 2026 11:02
@product-auto-label product-auto-label Bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Jul 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new example files demonstrating appendable object operations (finalize, pause/resume, read tail, and write) for Google Cloud Storage, gated under the unstable-stream feature. The feedback suggests improving code readability in lib.rs by using imported types directly instead of fully qualified paths, and removing redundant flush() calls before close() and finalize() operations since those methods perform flushing internally.

Comment thread src/storage/examples/src/lib.rs Outdated
Comment thread src/storage/examples/src/objects/open_appendable_object_pause_resume.rs Outdated
Comment thread src/storage/examples/src/objects/open_appendable_object_write.rs Outdated
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.03%. Comparing base (d7c735b) to head (318502d).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6225      +/-   ##
==========================================
- Coverage   96.03%   96.03%   -0.01%     
==========================================
  Files         269      269              
  Lines       67566    67566              
==========================================
- Hits        64888    64884       -4     
- Misses       2678     2682       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn force-pushed the appendable_upload_6 branch from c4eeeda to c974d54 Compare July 30, 2026 12:30
@vsharonlynn
vsharonlynn marked this pull request as ready for review July 30, 2026 12:31
@vsharonlynn
vsharonlynn requested review from a team as code owners July 30, 2026 12:31
Comment thread src/storage/examples/src/lib.rs Outdated
Comment thread src/storage/examples/Cargo.toml Outdated
@vsharonlynn
vsharonlynn force-pushed the appendable_upload_6 branch from 08173a0 to 318502d Compare July 30, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants