chore(spanner): configure built-in metrics reader - #6242
Open
olavloite wants to merge 1 commit into
Open
Conversation
olavloite
commented
Jul 31, 2026
Contributor
- Configure the built-in metrics reader to export once every 60s
- Set up bucket boundaries
- Disable built-in metrics when connected to the emulator
- Harden the parsing of server timings
- Configure the built-in metrics reader to export once every 60s - Set up bucket boundaries - Disable built-in metrics when connected to the emulator - Harden the parsing of server timings
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Spanner observability and metrics module by adding support to disable metrics when using the emulator, defining custom bucket boundaries for latency histograms, and setting a default 60-second export interval. It also refactors server timing parsing for better validation and adds comprehensive unit tests to verify these changes. I have no feedback to provide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6242 +/- ##
==========================================
+ Coverage 96.05% 96.10% +0.04%
==========================================
Files 271 271
Lines 68537 68681 +144
==========================================
+ Hits 65835 66004 +169
+ Misses 2702 2677 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.