Skip to content

cleanup(bigquery): make error mod pub; cleanup allows - #6252

Open
dbolduc wants to merge 2 commits into
googleapis:mainfrom
dbolduc:cleanup-bq-lib
Open

cleanup(bigquery): make error mod pub; cleanup allows#6252
dbolduc wants to merge 2 commits into
googleapis:mainfrom
dbolduc:cleanup-bq-lib

Conversation

@dbolduc

@dbolduc dbolduc commented Jul 31, 2026

Copy link
Copy Markdown
Member

I need to make the error mod public, and then I rearranged some things.

Fixes #5664

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Jul 31, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes modules in lib.rs, exposing error as a public module, and renames the handle field in Runner to _handle to suppress dead code warnings. Feedback suggests using #[allow(dead_code)] on the handle field instead of renaming it, which avoids propagating the rename to all destructuring patterns in the test suite.

Comment thread src/bigquery-write/src/runner.rs Outdated
@dbolduc
dbolduc marked this pull request as ready for review July 31, 2026 21:12
@dbolduc
dbolduc requested a review from a team as a code owner July 31, 2026 21:12
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (0dac6ea) to head (2ab7637).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6252   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         275      275           
  Lines       68829    68829           
=======================================
+ Hits        66126    66129    +3     
+ Misses       2703     2700    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define basic client surface

1 participant