Skip to content

refactor(dbkit/sqlite): wait for a lock through modernc.org/sqlite v1.61.0's busy handler #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SirLouen merged 3 commits into from
Oct 22, 2026
Merged

refactor(dbkit/sqlite): wait for a lock through modernc.org/sqlite v1.61.0's busy handler #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9010d
fix(dbkit/sqlite): run on modernc.org/sqlite v1.61.0 and libc v1.79.0
SirLouen Oct 21, 2026
bcacef0
refactor(dbkit/sqlite): wait for a lock through the driver's busy han…
SirLouen Oct 22, 2026
5f4155f
test(dbkit/sqlite): start the later-step deadline right before the st…
SirLouen Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dbkit/sqlite/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ linters:
- github.com/gopherium/framework/dbkit
- github.com/pressly/goose/v3
- modernc.org/sqlite
- modernc.org/libc
- golang.org/x/sys
exclusions:
rules:
Expand Down
10 changes: 10 additions & 0 deletions dbkit/sqlite/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,18 @@ Releases of this module are tagged `dbkit/sqlite/vX.Y.Z`.

### Changed

- **Breaking.** Requires `modernc.org/sqlite` v1.61.0 and `modernc.org/libc` v1.79.0, and `LibcVersion` is v1.79.0.
- **Breaking.** A `BeginTx` error after its context ends matches only the context error, no longer `dbkit.ErrBusy`, unless opening its connection answered busy.
- **Breaking.** A lock wait that starts while reading a later row of a query, or closing its rows, ends at `BusyTimeout` and not with the query's context.
- **Breaking.** A connection waiting for a lock tries again on SQLite's own schedule, up to every 100ms, so `BusyPoll` only paces opening a connection.
- Each connection waits for a lock through the driver's own busy handler, so `PRAGMA busy_timeout` reads `BusyTimeout` again.
- `sql.Conn.Raw` hands out the driver's own connection again.
- The module needs Go 1.27.3.

### Removed

- dbkit's own busy handler and its read of a private field of the driver.

## [0.2.0] - 2026-10-20

### Added
Expand Down
331 changes: 0 additions & 331 deletions dbkit/sqlite/busy.go
View file
Open in desktop

This file was deleted.

Loading
Loading