Skip to content

feat(internal/config): reduce calling libclang mutiple times #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeteorsLiu wants to merge 44 commits into
base: main
Choose a base branch
from

fix: trie name

8c25072
Select commit
Loading
Failed to load commit list.
Open

feat(internal/config): reduce calling libclang mutiple times #423

fix: trie name
8c25072
Select commit
Loading
Failed to load commit list.
qiniu-x / note-check completed Jun 6, 2025 in 7s

note-check found 2 issues related to your changes

This is the detailed log.

If you have any questions about this comment, feel free to raise an issue here.

Details

🔍 Check Results Details

The following shows all issues found related to your changes:

_xtool/internal/header/header_test.go:109: A Note is recommended to use "MARKER(uid): note body" format.
_xtool/internal/header/header_test.go:131: A Note is recommended to use "MARKER(uid): note body" format.

🔄 How to Handle?

  1. Fix the issues above and submit your code again
  2. Or click the Re-run button to run the check again
  3. If you think this is a false positive, please contact your support team

ℹ️ Notes

  • To avoid too many comments, only the top 10 issues will be shown in PR comments
  • For any other issues, feel free to create an issue in reviewbot repository
View more details on qiniu-x