Skip to content

Remove order of routing conditions in live view#2939

Merged
thomasiles merged 1 commit into
mainfrom
fix-live-view
Jul 16, 2026
Merged

Remove order of routing conditions in live view#2939
thomasiles merged 1 commit into
mainfrom
fix-live-view

Conversation

@thomasiles

Copy link
Copy Markdown
Contributor

I tried to fix a flaky test be making the live view order the routing conditions under a question. I used the same logic we use to order conditions for multiple branches.

This broke the live question view for forms with multiple secondary skips on the same page. These pages have multiple routing conditions but the page won't have selection options, which caused multiple errors in the alerts channel.

This commit abandons the change, reverting to how the file was before I made the change. It also marks the test as flaky once again.

What problem does this pull request solve?

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

I tried to fix a flaky test be making the live view order the routing
conditions under a question. I used the same logic we use to order
conditions for multiple branches.

This broke the live question view for forms with multiple secondary
skips on the same page. These pages have multiple routing conditions
but the page won't have selection options, which caused multiple errors
in the alerts channel.

This commit abandons the change, reverting to how the file was before I
made the change. It also marks the test as flaky once again.
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2939.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles
thomasiles marked this pull request as ready for review July 16, 2026 10:10
@thomasiles
thomasiles added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 7ffbd31 Jul 16, 2026
4 checks passed
@thomasiles
thomasiles deleted the fix-live-view branch July 16, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants