Remove order of routing conditions in live view#2939
Merged
Conversation
I tried to fix a flaky test be making the live view order the routing conditions under a question. I used the same logic we use to order conditions for multiple branches. This broke the live question view for forms with multiple secondary skips on the same page. These pages have multiple routing conditions but the page won't have selection options, which caused multiple errors in the alerts channel. This commit abandons the change, reverting to how the file was before I made the change. It also marks the test as flaky once again.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2939.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
thomasiles
marked this pull request as ready for review
July 16, 2026 10:10
DavidBiddle
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix a flaky test be making the live view order the routing conditions under a question. I used the same logic we use to order conditions for multiple branches.
This broke the live question view for forms with multiple secondary skips on the same page. These pages have multiple routing conditions but the page won't have selection options, which caused multiple errors in the alerts channel.
This commit abandons the change, reverting to how the file was before I made the change. It also marks the test as flaky once again.
What problem does this pull request solve?
Trello card:
Things to consider when reviewing