Skip to content

Add unique index to delivery_configurations and add DeliveryConfigurations for seeds#2941

Merged
stephencdaly merged 2 commits into
mainfrom
create-unique-index-on-delivery-configuration
Jul 17, 2026
Merged

Add unique index to delivery_configurations and add DeliveryConfigurations for seeds#2941
stephencdaly merged 2 commits into
mainfrom
create-unique-index-on-delivery-configuration

Conversation

@stephencdaly

@stephencdaly stephencdaly commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/WMnjLlJV/

There can only be one delivery configuration per form with the same delivery_method and delivery_schedule. Add a unique index to enforce this at the database level.

Also add DeliveryConfigurations for the seed forms.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

There can only be one delivery configuration per form with the same
delivery_method and delivery_schedule. Add a unique index to enforce
this at the database level.
@stephencdaly stephencdaly changed the title Add unique index to delivery_configurations Add unique index to delivery_configurations and add DeliveryConfigurations for seeds Jul 17, 2026
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2941.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly
stephencdaly enabled auto-merge July 17, 2026 15:20
@stephencdaly
stephencdaly added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 0b4b1c7 Jul 17, 2026
5 checks passed
@stephencdaly
stephencdaly deleted the create-unique-index-on-delivery-configuration branch July 17, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants