Use delivery_configurations to decide whether to send batch emails#2220
Open
stephencdaly wants to merge 1 commit into
Open
Use delivery_configurations to decide whether to send batch emails#2220stephencdaly wants to merge 1 commit into
stephencdaly wants to merge 1 commit into
Conversation
We are replacing the `send_daily_submission_batch` and `send_weekly_submission_batch` form attributes with `delivery_configurations` with a `delivery_schedule` of "daily" or "weekly". Update the BatchSubmissionsSelector to look at whether the appropriate delivery_configurations exist to decide whether to send batched submissions for a form. We need to maintain backwards compatibility, and look at the old attributes if the delivery_configurations are not present to support Submissions that were created before the delivery_configurations were added. This backwards compatibility can be removed once all Submissions without delivery_configurations on the form document have been deleted.
stephencdaly
force-pushed
the
use-delivery-configurations-for-batch-emails
branch
from
July 17, 2026 15:31
e662b7e to
0e514a1
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/WMnjLlJV
We are replacing the
send_daily_submission_batchandsend_weekly_submission_batchform attributes withdelivery_configurationswith adelivery_scheduleof "daily" or "weekly".Update the BatchSubmissionsSelector to look at whether the appropriate delivery_configurations exist to decide whether to send batched submissions for a form.
We need to maintain backwards compatibility, and look at the old attributes if the delivery_configurations are not present to support Submissions that were created before the delivery_configurations were added. This backwards compatibility can be removed once all Submissions without delivery_configurations on the form document have been deleted.
Review notes:
I've duplicated all the tests for checking the old
send_daily_submission_batch/send_weekly_submission_batchattributes and checking thedelivery_configurations.The old tests are unchanged, but the indentation has changed - so hiding whitespace changes should help with reviewing.
Things to consider when reviewing