Operation tests for setImmediates by shaoboyan091 · Pull Request #4558 · gpuweb/cts

shaoboyan091 · 2026-01-12T06:28:45Z

Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder.

Add basic execution tests for scalar, vector, and struct types.
Add tests for partial updates and multiple updates (using range verification).
Add tests for pipeline switching (compatible and incompatible).
Add tests for large data (maxImmediateSize) with range verification.
Add tests for TypedArray arguments with offsets.
Add tests for mixing render pass and bundle execution.

Issue: #

Requirements for PR author:

All missing test coverage is tracked with "TODO" or .unimplemented().
New helpers are /** documented */ and new helper files are found in helper_index.txt.
Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

Tests are properly located.
Test descriptions are accurate and complete.
Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

github-actions · 2026-01-12T06:31:07Z

Results for build job (at 6ffc1ce):

+webgpu:api,operation,command_buffer,programmable,immediate:basic_execution:* - 51 cases, 51 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:update_data:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:pipeline_switch:* - 4 cases, 4 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:use_max_immediate_size:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:typed_array_arguments:* - 36 cases, 216 subcases (~6/case)
+webgpu:api,operation,command_buffer,programmable,immediate:multiple_updates_before_draw_or_dispatch:* - 3 cases, 3 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_pass_and_bundle_mix:* - 1 cases, 1 subcases (~1/case)
+webgpu:api,operation,command_buffer,programmable,immediate:render_bundle_isolation:* - 1 cases, 1 subcases (~1/case)
-TOTAL: 280650 cases, 2321809 subcases
+TOTAL: 280752 cases, 2322091 subcases

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Implement operation tests for setImmediates in ComputePassEncoder, RenderPassEncoder, and RenderBundleEncoder. - Add basic execution tests for scalar, vector, and struct types. - Add tests for partial updates and multiple updates (using range verification). - Add tests for pipeline switching (no inheritance). - Add tests for large data (maxImmediateSize) with range verification. - Add tests for TypedArray arguments with offsets. - Add tests for mixing render pass and bundle execution.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shaoboyan091 · 2026-03-05T05:52:26Z

Softly ping for review.

Kangz · 2026-03-06T17:15:02Z

The operation tests seem to have good coverage. They became much simpler when the group decided to add validation that all immediates are set instead of defaulting to 0.

Kangz

Wow Github's code review UI is really annoying to use.

Kangz

Almost there

shaoboyan091 · 2026-03-13T02:37:03Z

I think I've resolved comments. PTAL, thanks !

greggman · 2026-03-26T21:05:30Z

+    if (!this.isCompatibility) {
+      return;
+    }
+    const needsStorageBuffersInFragmentStage =


If I understand correctly, this test is skipped on devices that don't support storage buffers in fragment shaders. But, those device do support immediates meaning this test fails to test immediates in fragment shaders on those device.

Should the test be refactored not to use storage buffers in fragment shaders? Many other tests were refactored to do this.

Fair point. I think we need to refactor this to cover more devices. Is there anyone working a uniform refactor for all test cases or we could do it seperately.

I think I refactored all exsiting tests to not require storage buffers in fragment shaders (except for the tests that are specifically testing storage buffers in fragment shaders 😛) If there are any left I'm happy to fix them.

…sInFragmentStage greggman@ pointed out that the previous immediates operation tests relies on StorageBuffersInFragmentStage, which will reduce the cover rate of the devices. (gpuweb#4558 (comment)) Remove usage of StorageBuffersInFragmentStage and directly rendering result out to do operation test

…sInFragmentStage (#4619) greggman@ pointed out that the previous immediates operation tests relies on StorageBuffersInFragmentStage, which will reduce the cover rate of the devices. (#4558 (comment)) Remove usage of StorageBuffersInFragmentStage and directly rendering result out to do operation test

shaoboyan091 force-pushed the immediate-operation branch from 834cd4a to 509b754 Compare February 10, 2026 08:41

shaoboyan091 requested a review from Copilot February 10, 2026 08:42

Copilot started reviewing on behalf of shaoboyan091 February 10, 2026 08:43 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

shaoboyan091 requested a review from Copilot February 11, 2026 01:48

Copilot started reviewing on behalf of shaoboyan091 February 11, 2026 01:49 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

shaoboyan091 force-pushed the immediate-operation branch 2 times, most recently from 2c527ae to ffe4c7c Compare February 24, 2026 06:26

shaoboyan091 requested a review from Copilot February 24, 2026 06:28

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 06:28 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated

shaoboyan091 force-pushed the immediate-operation branch 2 times, most recently from 4c8a817 to 7e4e8d8 Compare February 24, 2026 07:26

shaoboyan091 requested a review from Copilot February 24, 2026 07:49

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 07:49 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated

shaoboyan091 force-pushed the immediate-operation branch from 7e4e8d8 to 2e3521f Compare February 24, 2026 07:56

shaoboyan091 force-pushed the immediate-operation branch from 2e3521f to 6f16cf5 Compare February 24, 2026 08:33

shaoboyan091 requested a review from Copilot February 24, 2026 08:34

Copilot started reviewing on behalf of shaoboyan091 February 24, 2026 08:34 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

shaoboyan091 requested review from Kangz and kainino0x February 24, 2026 08:39

Kangz reviewed Mar 6, 2026

View reviewed changes

Address comments

079a9cd

shaoboyan091 marked this pull request as draft March 9, 2026 08:45

Kangz reviewed Mar 9, 2026

View reviewed changes

Iterate

f57ee4e

Kangz reviewed Mar 10, 2026

View reviewed changes

Iterating on typed array case and use outIndex every where

1ddbf94

shaoboyan091 marked this pull request as ready for review March 13, 2026 02:36

shaoboyan091 requested a review from Kangz March 13, 2026 02:36

Kangz approved these changes Mar 13, 2026

View reviewed changes

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts Outdated

Comment thread src/webgpu/api/operation/command_buffer/programmable/immediate.spec.ts

Address comments

af03a72

Kangz approved these changes Mar 16, 2026

View reviewed changes

Merge branch 'main' into immediate-operation

6ffc1ce

Kangz merged commit 81bf5e9 into gpuweb:main Mar 16, 2026
1 check passed

greggman reviewed Mar 26, 2026

View reviewed changes

shaoboyan091 mentioned this pull request Mar 30, 2026

Refactor immediate operation test to drop dependency on StorageBuffer… #4619

Merged

8 tasks

Conversation

shaoboyan091 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

shaoboyan091 commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kangz commented Mar 6, 2026

Uh oh!

Kangz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kangz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaoboyan091 commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greggman Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

shaoboyan091 Mar 27, 2026

shaoboyan091 commented Jan 12, 2026 •

edited

Loading

github-actions Bot commented Jan 12, 2026 •

edited

Loading