Shift left learning-path packaging checks (framing, depends, website.yaml description + trailing newline) - #434
Open
bonnywelsford-source wants to merge 3 commits into
Open
Conversation
Add CI validation for framing-out-of-milestones, first hands-on depends, and required website.yaml description so LP PRs fail before review instead of after green Pathfinder checks. Backfill missing Azure descriptions so main stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
bonnywelsford-source
requested review from
HCloward,
Jayclifford345,
leslie-heinzen,
moxious and
tomglenn
as code owners
July 14, 2026 00:42
pathfinder-app@main requires Node >=24; Node 22 npm ci rejects the current lockfile (Missing typescript@5.9.3), which was breaking validate-packages on all recent PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
CI failure on https://github.com/grafana/interactive-tutorials/actions/runs/29296638582 was not from the new packaging script — it died earlier at Root cause: pathfinder-app now declares |
Catch the deploy-preview Hugo front-matter break (missing final newline merges into type: docs) in Validate Interactive Packages instead of only at preview build time. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewers (see #418) keep re-finding the same Learning Hub packaging issues on LP PRs after Pathfinder CI is already green:
milestones(should stay on disk for the website only)dependson framingwebsite.yamldescription(required for Learning Hub meta / listings)website.yaml(deploy-preview concatenatestype: docsaftercat, which breaks Hugo YAML — same class of failure as #453 / #419)This PR encodes those rules in a script + CI so authors catch them before review, and documents the single source of truth for authoring and the LP review skill.
What changed
.github/scripts/validate_learning_path_packages.py.github/workflows/validate-json.ymldocs/website-yaml-reference.md.cursor/skills/review-learning-path/reference-checks.md.cursor/commands/create-learning-path/README.mdTest plan
python3 .github/scripts/validate_learning_path_packages.pypasses on this branchwebsite.yamlfails the script with a clear message