fix(deps): update requester (major)#489
Open
renovate-sh-app[bot] wants to merge 1 commit intomainfrom
Open
Conversation
hedss
previously approved these changes
Feb 17, 2026
renovate-sh-app
Bot
force-pushed
the
renovate/major-requester
branch
from
57378f3 to
471deb3
Compare
renovate-sh-app
Bot
added
the
dependencies
| datasource | package | from | to | | ---------- | ------------ | ------ | ----- | | npm | amqplib | 0.10.9 | 1.0.1 | | npm | package.json | 0.0.0 | 2.0.1 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
renovate-sh-app
Bot
force-pushed
the
renovate/major-requester
branch
from
471deb3 to
441709e
Compare
renovate-sh-app
Bot
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: amqplib v1.0 breaks OpenTelemetry instrumentation compatibility
- Downgraded
amqplibfrom^1.0.0to^0.10.9insource/mythical-beasts-requesterand regenerated the lockfile so OpenTelemetry amqplib auto-instrumentation remains in its supported version range.
- Downgraded
Or push these changes by commenting:
@cursor push d8f9aec9cf
Preview (d8f9aec9cf)
diff --git a/source/mythical-beasts-requester/package-lock.json b/source/mythical-beasts-requester/package-lock.json
--- a/source/mythical-beasts-requester/package-lock.json
+++ b/source/mythical-beasts-requester/package-lock.json
@@ -19,7 +19,7 @@
"@opentelemetry/sdk-trace-node": "^2.2.0",
"@opentelemetry/semantic-conventions": "^1.38.0",
"@pyroscope/nodejs": "^0.4.8",
- "amqplib": "^1.0.0",
+ "amqplib": "^0.10.9",
"axios": "^1.13.2",
"express": "^5.2.1",
"package.json": "^2.0.0",
@@ -1699,15 +1699,16 @@
}
},
"node_modules/amqplib": {
- "version": "1.0.2",
- "resolved": "https://registry.npmjs.org/amqplib/-/amqplib-1.0.2.tgz",
- "integrity": "sha512-QFzavIs3FxXA9/PWOiY/j5Arr7KFT0b1TYYsq9f5PyZ3Dv5H5hQXTK3fZTUUzzOo2BF1o/Vk5bHAKzlL40LfDA==",
+ "version": "0.10.9",
+ "resolved": "https://registry.npmjs.org/amqplib/-/amqplib-0.10.9.tgz",
+ "integrity": "sha512-jwSftI4QjS3mizvnSnOrPGYiUnm1vI2OP1iXeOUz5pb74Ua0nbf6nPyyTzuiCLEE3fMpaJORXh2K/TQ08H5xGA==",
"license": "MIT",
"dependencies": {
- "buffer-more-ints": "~1.0.0"
+ "buffer-more-ints": "~1.0.0",
+ "url-parse": "~1.5.10"
},
"engines": {
- "node": ">=18"
+ "node": ">=10"
}
},
"node_modules/ansi-regex": {
@@ -3207,6 +3208,12 @@
"url": "https://github.com/sponsors/ljharb"
}
},
+ "node_modules/querystringify": {
+ "version": "2.2.0",
+ "resolved": "https://registry.npmjs.org/querystringify/-/querystringify-2.2.0.tgz",
+ "integrity": "sha512-FIqgj2EUvTa7R50u0rGsyTftzjYmv/a3hO345bZNrqabNqjtgiDMgmo4mkUjd+nzU5oF3dClKqFIPUKybUyqoQ==",
+ "license": "MIT"
+ },
"node_modules/r-json": {
"version": "1.3.1",
"resolved": "https://registry.npmjs.org/r-json/-/r-json-1.3.1.tgz",
@@ -3338,6 +3345,12 @@
"node": ">=9.3.0 || >=8.10.0 <9.0.0"
}
},
+ "node_modules/requires-port": {
+ "version": "1.0.0",
+ "resolved": "https://registry.npmjs.org/requires-port/-/requires-port-1.0.0.tgz",
+ "integrity": "sha512-KigOCHcocU3XODJxsu8i/j8T9tzT4adHiecwORRQ0ZZFcp7ahwXuRU1m+yuO90C5ZUyGeGfocHDI14M3L3yDAQ==",
+ "license": "MIT"
+ },
"node_modules/resolve": {
"version": "1.22.11",
"resolved": "https://registry.npmjs.org/resolve/-/resolve-1.22.11.tgz",
@@ -3721,6 +3734,16 @@
"node": ">=0.10"
}
},
+ "node_modules/url-parse": {
+ "version": "1.5.10",
+ "resolved": "https://registry.npmjs.org/url-parse/-/url-parse-1.5.10.tgz",
+ "integrity": "sha512-WypcfiRhfeUP9vvF0j6rw0J3hrWrw6iZv3+22h6iRMJ/8z1Tj6XfLP4DsUix5MhMPnXpiHDoKyoZ/bdCkwBCiQ==",
+ "license": "MIT",
+ "dependencies": {
+ "querystringify": "^2.1.1",
+ "requires-port": "^1.0.0"
+ }
+ },
"node_modules/url-parse-lax": {
"version": "1.0.0",
"resolved": "https://registry.npmjs.org/url-parse-lax/-/url-parse-lax-1.0.0.tgz",
diff --git a/source/mythical-beasts-requester/package.json b/source/mythical-beasts-requester/package.json
--- a/source/mythical-beasts-requester/package.json
+++ b/source/mythical-beasts-requester/package.json
@@ -20,7 +20,7 @@
"@opentelemetry/sdk-trace-node": "^2.2.0",
"@opentelemetry/semantic-conventions": "^1.38.0",
"@pyroscope/nodejs": "^0.4.8",
- "amqplib": "^1.0.0",
+ "amqplib": "^0.10.9",
"axios": "^1.13.2",
"express": "^5.2.1",
"package.json": "^2.0.0",You can send follow-ups to this agent here.
| "@opentelemetry/semantic-conventions": "^1.38.0", | ||
| "@pyroscope/nodejs": "^0.4.8", | ||
| "amqplib": "^0.10.9", | ||
| "amqplib": "^1.0.0", |
There was a problem hiding this comment.
amqplib v1.0 breaks OpenTelemetry instrumentation compatibility
High Severity
Upgrading amqplib to ^1.0.0 breaks compatibility with @opentelemetry/instrumentation-amqplib (v0.58.0), which only supports amqplib versions >=0.5.5 <1. This project uses @opentelemetry/auto-instrumentations-node for distributed tracing, which includes the amqplib instrumentation. With amqplib v1.0+, AMQP/RabbitMQ trace spans will silently stop being generated, breaking observability for the message queue path.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.10.9→^1.0.0^0.0.0→^2.0.0Release Notes
amqp-node/amqplib (amqplib)
v1.0.3Compare Source
v1.0.2Compare Source
v1.0.1Compare Source
v1.0.0Compare Source
IonicaBizau/pkg.json (package.json)
v2.0.1Compare Source
Fix #5. Fix the npm docs.
v1.0.2Compare Source
babel-itto babelify the code, so the module is now compatible with older versions of Node.js.v1.0.1Compare Source
Whitelist the npm files.
v1.0.0Configuration
📅 Schedule: (UTC)
* * 1 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
Need help?
You can ask for more help in the following Slack channel: #proj-renovate-self-hosted. In that channel you can also find ADR and FAQ docs in the Resources section.