refactor(distributor): remove deprecated receivedDecompressedBytes metric#5292
Open
faisalaffan wants to merge 4 commits into
Open
refactor(distributor): remove deprecated receivedDecompressedBytes metric#5292faisalaffan wants to merge 4 commits into
faisalaffan wants to merge 4 commits into
Conversation
…tric This metric has been superseded by receivedDecompressedBytesTotal which provides finer-grained observability with stage labels (received, sampled, normalized) instead of only tracking the sampled stage. The replacement observeProfileSize() helper is already called at all three processing stages (StageReceived, StageSampled, StageNormalized).
…etric The deprecated distributor_received_decompressed_bytes metric has been removed. This metric tracks the same data with an additional usage_group label.
Keep the existing TODO about using req.TotalBytesUncompressed for the sampled stage metric, but format it as a proper comment above the call rather than an inline trailing comment that was lost when removing the deprecated receivedDecompressedBytes metric.
faisalaffan
requested review from
aleks-p,
alsoba13 and
marcsanmi
as code owners
June 26, 2026 08:36
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the deprecated
pyroscope_distributor_received_decompressed_byteshistogram metric from the distributor, which has been marked
TODO removeand self-documented as deprecated in its own help text.
Why
This metric was superseded by
pyroscope_distributor_received_decompressed_bytes_total,which provides finer-grained observability with
stagelabels (received,sampled,normalized) instead of only tracking a single processing stage withtypelabels.The replacement
observeProfileSize()helper was already being called at all threeprocessing stages — the deprecated metric was simply a duplicate observation that
added no value.
Changes
receivedDecompressedBytesfield, histogram creation,registration, and the observe call at the sampled stage
usage_groups.gothat referenced theremoved metric name
req.TotalBytesUncompressedat the sampled stage as a proper doc comment
Dashboard Migration (follow-up)
Dashboard queries in
operations/still referencepyroscope_distributor_received_decompressed_bytes.These need migration to
_totalwith appropriatestageselectors — the label structurechanged from
{type, tenant}to{tenant, stage}.Testing