Fix: Mount v1Router to enable /api/v1/* routes

[bbjiggy]

Closes #9

Changes

• Imported and mounted v1Router at /api/v1 (canonical namespace)
• Added legacyApiDeprecation middleware to /api routes (legacy namespace)
• Both namespaces now work as documented

Testing

# Canonical v1 endpoint now works
curl http://localhost:3001/api/v1/portfolio/GABC...

# Legacy endpoint still works with deprecation headers
curl -I http://localhost:3001/api/portfolio/GABC...

[Uchechukwu-Ekezie]

Good targeted fix — mounts v1Router at the canonical /api/v1 namespace and wraps the legacy /api routes with a deprecation middleware. A few things worth discussing before merge:

Route ordering looks correct. Express matches in declaration order, so /api/v1/* hits v1Router before the broader /api prefix kicks in. No issue there.

The app.use('/', portfolioRouter) mount is a concern. This was pre-existing, but with this PR now explicitly formalizing the namespace strategy it's worth addressing: any route defined in portfolioRouter (e.g. /portfolio/:address) is now reachable at both /api/portfolio/:address and /portfolio/:address (root-level). That's likely unintentional exposure and should be removed or documented.

v1Router contents aren't visible in this diff. The fix assumes v1Router already exists and is correct — but we can't verify whether it exposes the same contract as the documented /api/v1/* endpoints, or if it's a thin re-export of portfolioRouter. Worth a quick note confirming what's inside, especially since this is the canonical namespace going forward.

No test coverage added. Even a single integration test confirming GET /api/v1/portfolio/:address returns 200 and GET /api/portfolio/:address returns 200 with a deprecation header would lock this in and prevent future regressions.

The core change is minimal and the intent is sound. Clean up the root mount concern and we're good.

[bbjiggy]

Good targeted fix — mounts v1Router at the canonical /api/v1 namespace and wraps the legacy /api routes with a deprecation middleware. A few things worth discussing before merge:

Route ordering looks correct. Express matches in declaration order, so /api/v1/* hits v1Router before the broader /api prefix kicks in. No issue there.

The app.use('/', portfolioRouter) mount is a concern. This was pre-existing, but with this PR now explicitly formalizing the namespace strategy it's worth addressing: any route defined in portfolioRouter (e.g. /portfolio/:address) is now reachable at both /api/portfolio/:address and /portfolio/:address (root-level). That's likely unintentional exposure and should be removed or documented.

v1Router contents aren't visible in this diff. The fix assumes v1Router already exists and is correct — but we can't verify whether it exposes the same contract as the documented /api/v1/* endpoints, or if it's a thin re-export of portfolioRouter. Worth a quick note confirming what's inside, especially since this is the canonical namespace going forward.

No test coverage added. Even a single integration test confirming GET /api/v1/portfolio/:address returns 200 and GET /api/portfolio/:address returns 200 with a deprecation header would lock this in and prevent future regressions.

The core change is minimal and the intent is sound. Clean up the root mount concern and we're good.

It's done.
I've removed root mount - app.use('/', portfolioRouter).

Added integration tests - Tests verify:

• /api/v1/prices returns 200 (canonical)
• /api/prices returns 200 with deprecation headers (legacy)
• Both namespaces return same data structure
• Root-level routes are not exposed

[Uchechukwu-Ekezie]

Thanks I will review shortly

[Uchechukwu-Ekezie]

nice job