fix(#3): uncomment notification test endpoints#24
Merged
Uchechukwu-Ekezie merged 1 commit intoJun 24, 2026
Merged
Conversation
POST /api/notifications/test and POST /api/notifications/test-all were wrapped in block comments, causing documented API routes to return 404. Uncommented both handlers and applied blockDebugInProduction middleware to match the existing pattern used by all other test/debug routes, ensuring the endpoints are unavailable in production environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
What changed
backend/src/api/routes.ts:POST /api/notifications/test(lines 808–910)POST /api/notifications/test-all(lines 912–998)blockDebugInProductionmiddleware to both routesWhy
Both endpoints were fully implemented but wrapped in block comments, causing any call from the documented curl examples or the
NotificationTest.tsxfrontend component to return404 Route not found.The
blockDebugInProductionmiddleware is the existing pattern used by all other test/debug routes (/debug/coingecko-test,/debug/force-fresh-prices, etc.). Applying it here keeps the test endpoints consistent — available in development, blocked in production.How to test