feat: retry before recreating grpc client#182
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts gRPC retry behavior so that the client is only re-created when a request should not be retried, and expands the set of retryable status codes to include DEADLINE_EXCEEDED. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The interplay between
shouldRetryandshouldRecreateServiceis now implicit; consider extracting a small helper or adding a clear precedence rule (e.g., retry takes priority over recreate) to keep this behavior easy to reason about and avoid future regressions. - Now that
DEADLINE_EXCEEDEDis added toRETRYABLE_STATUS_CODES, check whether it overlaps with any codes that also trigger service recreation and, if so, centralize that mapping to avoid diverging retry/recreate behavior for the same status.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The interplay between `shouldRetry` and `shouldRecreateService` is now implicit; consider extracting a small helper or adding a clear precedence rule (e.g., retry takes priority over recreate) to keep this behavior easy to reason about and avoid future regressions.
- Now that `DEADLINE_EXCEEDED` is added to `RETRYABLE_STATUS_CODES`, check whether it overlaps with any codes that also trigger service recreation and, if so, centralize that mapping to avoid diverging retry/recreate behavior for the same status.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
SeqviriouM
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Adjust gRPC retry behavior to prefer retrying over client recreation for retryable errors and expand the set of retryable gRPC status codes.
Bug Fixes:
Enhancements: