lf_interop_zoom.py: fix stale upstream_port and host/client script paths - #313
Open
Narayana-CT wants to merge 2 commits into
Open
lf_interop_zoom.py: fix stale upstream_port and host/client script paths#313Narayana-CT wants to merge 2 commits into
Narayana-CT wants to merge 2 commits into
Conversation
Sync zoom_automation.upstream_port with the resolved IP after change_port_to_ip() converts a LANforge port name (e.g. 1.1.eth1) to an IP. Previously only the local args.upstream_port variable was updated, so the Flask client on the host device kept using the raw port name and failing with NameResolutionError. Also point the generated host/client commands at the deployed zoom.bat/ctzoom.bash locations via WINDOWS_ZOOM_DIR, LINUX_ZOOM_DIR, and MACOS_ZOOM_DIR instead of relying on scripts in the working directory. Verified CLI: python3 lf_interop_zoom.py --duration 2 --lanforge_ip "192.168.244.97" --signin_email "demo@gmail.com" --signin_passwd 'demo' --participants 2 --audio --video --upstream_port 1.1.eth1 --api_stats_collection --env_file .env Signed-off-by: Narayana-CT <narayana.pinapatruni@candelatech.com>
Allow overriding the zoom automation script deployment paths per OS instead of relying on the hardcoded WINDOWS_ZOOM_DIR/LINUX_ZOOM_DIR/ MACOS_ZOOM_DIR constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync zoom_automation.upstream_port with the resolved IP after change_port_to_ip() converts a LANforge port name (e.g. 1.1.eth1) to an IP. Previously only the local args.upstream_port variable was updated, so the Flask client on the host device kept using the raw port name and failing with NameResolutionError.
Also point the generated host/client commands at the deployed zoom.bat/ctzoom.bash locations via WINDOWS_ZOOM_DIR, LINUX_ZOOM_DIR, and MACOS_ZOOM_DIR instead of relying on scripts in the working directory.
Verified CLI: python3 lf_interop_zoom.py --duration 2 --lanforge_ip "192.168.244.97" --signin_email "demo@gmail.com" --signin_passwd 'demo' --participants 2 --audio --video --upstream_port 1.1.eth1 --api_stats_collection --env_file .env