GCI91 - Create rule 'Use filter before sort' in java context - V.E.R.T.

src/it/test-projects/creedengo-java-plugin-test-project/src/main/java/org/greencodeinitiative/creedengo/java/checks/UseFilterBeforeSort.java

@@ -0,0 +1,21 @@
+package org.greencodeinitiative.creedengo.java.checks;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+class UseFilterBeforeSort {
+    UseFilterBeforeSort() {
+    }
+
+    public void manipulateStream(final List<String> list) {
+        list.stream() // Noncompliant {{Use 'filter' before 'sorted' for better efficiency.}}
+                .sorted()
+                .filter(s -> s.startsWith("A"))
+                .collect(Collectors.toList());
+
+        list.stream() // Compliant {{Use 'filter' before 'sorted' for better efficiency.}}
+                .filter(s -> s.startsWith("A"))
+                .sorted()
+                .collect(Collectors.toList());
+    }
+}

src/main/java/org/greencodeinitiative/creedengo/java/JavaCheckRegistrar.java

@@ -50,7 +50,8 @@ public class JavaCheckRegistrar implements CheckRegistrar {
             FreeResourcesOfAutoCloseableInterface.class,
             AvoidMultipleIfElseStatement.class,
             UseOptionalOrElseGetVsOrElse.class,
-            MakeNonReassignedVariablesConstants.class
+            MakeNonReassignedVariablesConstants.class,
+            UseFilterBeforeSort.class
     );
 
     /**

src/main/java/org/greencodeinitiative/creedengo/java/checks/UseFilterBeforeSort.java

@@ -0,0 +1,43 @@
+package org.greencodeinitiative.creedengo.java.checks;
+
+import org.sonar.check.Rule;
+import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
+import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree;
+import org.sonar.plugins.java.api.tree.MethodInvocationTree;
+import org.sonar.plugins.java.api.tree.Tree;
+
+import java.util.Arrays;
+import java.util.List;
+
+@Rule(key = "GCI91")
+public class UseFilterBeforeSort extends IssuableSubscriptionVisitor {
+    @Override
+    public List<Tree.Kind> nodesToVisit() {
+        return Arrays.asList(Tree.Kind.METHOD_INVOCATION);
+    }
+
+    @Override
+    public void visitNode(Tree tree) {
+        MethodInvocationTree methodInvocation = (MethodInvocationTree) tree;
+
+        // On vérifie si c’est un appel à "sorted"
+        if (methodInvocation.methodSelect() instanceof MemberSelectExpressionTree) {
+            MemberSelectExpressionTree sortedSelect = (MemberSelectExpressionTree) methodInvocation.methodSelect();
+            String sortedMethod = sortedSelect.identifier().name();
+
+            if ("sorted".equals(sortedMethod)) {
+                Tree methodCall = methodInvocation.parent();
+                if (methodCall instanceof MemberSelectExpressionTree) {
+                    MemberSelectExpressionTree filterCall = (MemberSelectExpressionTree) methodCall;
+                    String filterMethod = filterCall.identifier().name();
+
+                    if ("filter".equals(filterMethod)) {
+                        // Mauvais ordre détecté : sorted().filter() au lieu de filter().sorted()
+                        reportIssue(methodInvocation, "Use 'filter' before 'sorted' for better efficiency.");
+                    }
+                }
+            }
+        }
+    }
+
+}

src/main/resources/org/greencodeinitiative/creedengo/java/creedengo_way_profile.json

@@ -18,6 +18,7 @@
 	"GCI78",
 	"GCI79",
 	"GCI82",
+	"GCI91",
 	"GCI94"
   ]
 }

src/test/files/UseFilterBeforeSort.java

@@ -0,0 +1,35 @@
+/*
+ * creedengo - Java language - Provides rules to reduce the environmental footprint of your Java programs
+ * Copyright © 2024 Green Code Initiative (https://green-code-initiative.org/)
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.greencodeinitiative.creedengo.java.checks;
+
+class UseFilterBeforeSort {
+    UseFilterBeforeSort() {
+    }
+
+    public void manipulateStream(List<String> list) {
+        list.stream() // Noncompliant {{Use 'filter' before 'sorted' for better efficiency.}}
+                .sorted()
+                .filter(s -> s.startsWith("A"))
+                .collect(Collectors.toList());
+
+        list.stream() // Compliant {{Use 'filter' before 'sorted' for better efficiency.}}
+                .filter(s -> s.startsWith("A"))
+                .sorted()
+                .collect(Collectors.toList());
+    }
+}

src/test/java/org/greencodeinitiative/creedengo/java/checks/UseFilterBeforeSortTest.java

@@ -0,0 +1,14 @@
+package org.greencodeinitiative.creedengo.java.checks;
+
+import org.junit.jupiter.api.Test;
+import org.sonar.java.checks.verifier.CheckVerifier;
+
+public class UseFilterBeforeSortTest {
+    @Test
+    void testHasIssues() {
+        CheckVerifier.newVerifier()
+                .onFile("src/test/files/UseFilterBeforeSort.java")
+                .withCheck(new UseFilterBeforeSort())
+                .verifyIssues();
+    }
+}