Repository navigation
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Measurement fetch API src/services/study/state-estimation.ts, src/services/study/state-estimation.test.ts |
Adds a measurements request for a study, node, and root network. When filters are provided, the service encodes them as a globalFilters query parameter. Tests cover request URLs, responses, and failures. |
Measurement table rows src/components/results/stateestimation/state-estimation-result.type.ts, src/components/results/stateestimation/state-estimation-result-table.tsx, src/components/results/stateestimation/state-estimation-result-table.test.tsx |
Adds optional measurementRows input. The table uses supplied rows, falls back to rows in the full result, and returns empty arrays when applicable result data is absent. Tests cover row selection and grid behavior. |
Query-aware display and tab integration src/components/results/stateestimation/state-estimation-measurements.tsx, src/components/results/stateestimation/state-estimation-result-tab.tsx, src/components/results/stateestimation/state-estimation-measurements.test.tsx |
Adds query identity, loading, and stale-response handling for measurement requests. The result tab supplies global filters and shows the filter selector on the measurements tab. Tests cover query changes, saved filters, and tab behavior. |
Sequence Diagram(s)
sequenceDiagram
participant StateEstimationResultTab
participant StateEstimationMeasurements
participant fetchStateEstimationMeasurements
participant StateEstimationResultTable
StateEstimationResultTab->>StateEstimationMeasurements: Pass study, node, root network, and global filters
StateEstimationMeasurements->>fetchStateEstimationMeasurements: Request measurements for current criteria
fetchStateEstimationMeasurements-->>StateEstimationMeasurements: Return measurement rows
StateEstimationMeasurements->>StateEstimationResultTable: Supply rows for the current query
Suggested reviewers: meklo
Priority:
Merge Risk: 
322b6
-
No specific issue is established that would prevent merging after the normal checks.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly and concisely describes the main change: adding global filters to state-estimation measurements. Description check The description directly explains the global-filter behavior, new endpoint, component changes, persistence, client-side sorting and filtering, and test coverage. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…easurements' into feat/global-filters-estimation-measurements
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary — gridstudy-app
· feat: add global filters to state estimation measurements
State estimation Measurements tab now supports global filters: the user picks
criteria (countries, voltage ranges, substation properties, saved site/post
filters) and the table shows only matching measurements, fetched from the new
GET …/state-estimation/measurements?globalFilters=<json>endpoint (204 →empty table). Selections are persisted per study. Column filtering/sorting stay
client-side; the old
/resultcall is unchanged.StateEstimationMeasurementscomponent (1 s debounce, stale responses ignored, rows hidden until status SUCCEED/FAILED)fetchStateEstimationMeasurementsservice +GlobalFilterSelectorwiring in the result tabCross-repo: study-server + state-estimation server PRs.
Linked PR: gridsuite/study-server#1148