Skip to content

Report error on step execution - #136

Merged
FranckLecuyer merged 6 commits into
mainfrom
report_step_error
Oct 30, 2026
Merged

Report error on step execution#136
FranckLecuyer merged 6 commits into
mainfrom
report_step_error

Conversation

@FranckLecuyer

@FranckLecuyer FranckLecuyer commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

PR Summary

@FranckLecuyer
Report error on step execution
83d32ba 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 36ce15fa-edcd-4fa2-90af-57f0bd7b8364
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thangqp
clean try catch exception in computing step
7453030 
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@thangqp
clean test
a3dfcfd 
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@thangqp
clean test 2
deb099c 
Signed-off-by: Thang PHAM <phamthang37@gmail.com>
klesaulnier
klesaulnier approved these changes Oct 30, 2026
View reviewed changes
Comment thread ...r-worker-server/src/test/java/org/gridsuite/monitor/worker/server/utils/ReportTestUtils.java

@klesaulnier klesaulnier Oct 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename it ReportTestUtils ? I think in the future we'd rather have several utils class rather than a single one for all use cases

@FranckLecuyer FranckLecuyer Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread ...ver/src/main/java/org/gridsuite/monitor/worker/server/orchestrator/StepExecutionService.java Resolved
Comment thread ...r-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties

@klesaulnier klesaulnier Oct 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some keys are not used anymore, like "monitor.worker.server.loadflow.step.error"
same for monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports.properties

@FranckLecuyer FranckLecuyer Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FranckLecuyer
Fix conflicts and merge
b3bddbd 
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@FranckLecuyer
Remove no more used report keys
f0b67bb 
Renaming TestUtils to ReportTestUtils

Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FranckLecuyer
FranckLecuyer merged commit 1e3c8fe into main Oct 30, 2026
5 checks passed
@FranckLecuyer
FranckLecuyer deleted the report_step_error branch October 30, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klesaulnier klesaulnier klesaulnier approved these changes
@thangqp thangqp thangqp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FranckLecuyer @klesaulnier @thangqp