Repository navigation
referencing notification - #919
Open
souissimai wants to merge 23 commits into
Open
souissimai wants to merge 23 commits into
souissimai wants to merge 23 commits into
Conversation
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
SlimaneAmar
reviewed
Oct 22, 2026
| @@ -0,0 +1,14 @@ | |||
| package org.gridsuite.modification.server.utils; | |||
Contributor
Author
There was a problem hiding this comment.
@PostCompletion
public void emitModificationReferencesChanged , used
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
SlimaneAmar
reviewed
Oct 23, 2026
| public void deleteNetworkModifications(UUID groupUuid, List<UUID> modificationsUuids, @NonNull String userId) { | ||
| List<ModificationReferenceData> references = getModificationsReferencesToDelete(groupUuid, modificationsUuids); | ||
| handleDeleteNetworkModifications(groupUuid, modificationsUuids); | ||
| if (!references.isEmpty()) { |
| @Transactional | ||
| public void deleteNetworkModifications(UUID groupUuid, List<UUID> modificationsUuids, @NonNull String userId) { | ||
| List<ModificationReferenceData> references = getModificationsReferencesToDelete(groupUuid, modificationsUuids); | ||
| handleDeleteNetworkModifications(groupUuid, modificationsUuids); |
Contributor
There was a problem hiding this comment.
No need to do a DB request ?
Contributor
Author
There was a problem hiding this comment.
We do need it: the references have to be read before the deletion
|
|
||
| // the references among the assembled modifications are now located in the new composite | ||
| UUID groupUuid = modificationRepository.findGroupIdByModificationId(newComposite.getUuid()); | ||
| if (groupUuid != null) { |
Contributor
There was a problem hiding this comment.
Remove test
Do it in emitModificationReferencesChanged
added 3 commits
October 23, 2026 15:52
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary