Repository navigation
Conversation
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…not write on Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…t-network-applicabilities Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…rk-tags-on-shared-modifications Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…at/guard-root-network-tags-on-shared-modifications Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
…difications Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Meklo
reviewed
Oct 21, 2026
Comment on lines
+355
to
+360
| @Parameter(description = "Container UUIDs (groups or composites), whose content is checked") | ||
| @RequestParam(value = "containerUuids", required = false, defaultValue = "") List<UUID> containerUuids, | ||
| @Parameter(description = "Modification UUIDs, checked with their content") | ||
| @RequestParam(value = "modificationUuids", required = false, defaultValue = "") List<UUID> modificationUuids, | ||
| @Parameter(description = "Shared modification UUIDs, checked themselves and with their content") | ||
| @RequestParam(value = "sharedUuids", required = false, defaultValue = "") List<UUID> sharedUuids, |
Contributor
There was a problem hiding this comment.
These ids will be transmitted through the url, we sure it won't break because of url size limit ?
Contributor
Author
There was a problem hiding this comment.
Indeed maybe it was slightly optimistic :) I switch to POST with body and DTO
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…pplicabilities' into HEAD Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java
…pplicabilities' into HEAD Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…k tags Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…shared-modifications' into feat/guard-root-network-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java # src/test/java/org/gridsuite/modification/server/CompositeControllerTest.java
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…shared-modifications' into feat/guard-root-network-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/NetworkModificationController.java # src/main/java/org/gridsuite/modification/server/dto/RootNetworkTagsCheckInfos.java # src/test/java/org/gridsuite/modification/server/CompositeControllerTest.java
Meklo
approved these changes
Oct 22, 2026
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…pplicabilities' into feat/guard-root-network-tags-on-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…shared-modifications' into feat/guard-root-network-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/dto/RootNetworkTagsCheckInfos.java # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java # src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…nto feat/guard-root-network-tags-on-pasted-shared-modifications
…rk-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/test/java/org/gridsuite/modification/server/CompositeControllerTest.java
…rk-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/NetworkModificationController.java # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java # src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java
…l helpers Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com> # Conflicts: # src/main/java/org/gridsuite/modification/server/NetworkModificationController.java # src/main/java/org/gridsuite/modification/server/dto/RootNetworkTagsCheckInfos.java # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java # src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java # src/test/java/org/gridsuite/modification/server/CompositeControllerTest.java
flomillot
changed the base branch from
feat/guard-root-network-tags-on-shared-modifications
to
main
October 26, 2026 17:10
…ions Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…rk-tags-on-pasted-shared-modifications Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /containers/root-network-tags/authorizedalso checks the shared modifications referred to bymodificationUuidsand their content, and thesharedUuidsthemselves along with their content. The body getscontainerUuids,modificationUuidsandsharedUuids, a missing list being an empty one.