Repository navigation
Check permission shared modifications - #946
Merged
Merged
Conversation
basseche
requested review from
EtienneLt,
SlimaneAmar and
etiennehomer
as code owners
October 22, 2026 09:27
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Meklo
reviewed
Oct 23, 2026
Meklo
approved these changes
Oct 26, 2026
etiennehomer
approved these changes
Oct 26, 2026
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
check_permission_shared_modifications
branch
from
October 26, 2026 17:12
1ba8486 to
1c221ff
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When modification is shared and we remove write right for a user. If he is already on the study, he can still edit the modification once because there is no back check for the moment but only front disable.
We add the back check in this PR.