Skip to content

Resolve filter name through remote call instead of storage - #245

Open
Meklo wants to merge 13 commits into
mainfrom
marcellinh/remove-filter-name-storage
Open

Meklo wants to merge 13 commits into
mainfrom
marcellinh/remove-filter-name-storage

Conversation

@Meklo

@Meklo Meklo commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Summary

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 310e8c86-d125-429f-80b4-59f49bbe9aaf
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Meklo
Meklo requested a review from GhilesA October 12, 2026 13:01
@GhilesA
GhilesA requested a balanced review from Copilot October 14, 2026 08:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The filter traversal and fallback-label behavior are consistent, null-safe, and covered by focused tests.

0 open findings

What changed in this PR

Enables caller-side remote filter-name resolution by exposing referenced filters and providing ID-based label fallbacks.

Changes:

  • Adds filter-reference collection across applicable modification DTOs.
  • Unifies generator filters with FilterInfos.
  • Uses resolved names or filter IDs in reports.
File Description
ModificationFiltersTest.java Tests filter collection and label fallback.
ModificationUtils.java Uses safe filter labels in reports.
GenerationDispatch.java Uses labels during filter export.
AbstractScaling.java Uses labels in filter maps and warnings.
ScalingInfos.java Collects scaling filters.
ModificationInfos.java Defines the filter-collection API.
ModificationByAssignmentInfos.java Collects assignment filters.
GeneratorsFilterInfos.java Extends the common filter DTO.
GenerationDispatchInfos.java Collects dispatch filters.
FilterInfos.java Adds name-or-ID labels.
ByFormulaModificationInfos.java Collects formula filters.
ByFilterDeletionInfos.java Collects deletion filters.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/main/java/org/gridsuite/modification/dto/ByFormulaModificationInfos.java Outdated
@Meklo
Meklo requested a review from flomillot October 28, 2026 14:18
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants