Repository navigation
Ignore duplicated equipment in by filter modifications - #246
Merged
Merged
Conversation
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EtienneLt
commented
Oct 7, 2026
| assertEquals(75, twt1.getG(), 0); | ||
| assertEquals(25, twt1.getRatedU1(), 0); | ||
| assertEquals(10, twt1.getRatedU2(), 0); | ||
| assertEquals(44, twt1.getRatedS(), 0); |
Contributor
Author
There was a problem hiding this comment.
logical because twt1 is in filter 1 and in filter 2
EtienneLt
commented
Oct 9, 2026
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
etiennehomer
left a comment
etiennehomer
left a comment
Contributor
There was a problem hiding this comment.
I think we have a similar problem with generation dispatch and duplicated equipment and different distribution key
| network.modification.distributionKeys.missingEquipmentKey = Ventilation mode could not be applied: at least one equipment is missing a distribution key | ||
| network.modification.distributionKeys.unexpectedSum = Ventilation mode could not be applied: the total of the distribution keys of the selected equipment is zero | ||
| network.modification.distributionKeys.valid = Variation distribution keys have been validated | ||
| network.modification.distributionKeysNotFound = This mode is available only for equipment with distribution key |
| network.modification.distributionKeys.missingEquipmentKey = Ventilation mode could not be applied: at least one equipment is missing a distribution key | ||
| network.modification.distributionKeys.unexpectedSum = Ventilation mode could not be applied: the total of the distribution keys of the selected equipment is zero | ||
| network.modification.distributionKeys.valid = Variation distribution keys have been validated | ||
| network.modification.distributionKeysNotFound = This mode is available only for equipment with distribution key |
etiennehomer
left a comment
etiennehomer
left a comment
Contributor
There was a problem hiding this comment.
I think we have a similar problem with generation dispatch and duplicated equipment and different distribution key
|
etiennehomer
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
need to adapt network modification server tests