Repository navigation
Drop the table of the modifications to exclude - #1157
Conversation
The applicability per root network tag replaced the modifications a root network used to leave out, and the migration made those applicabilities explicit. Nothing reads the table any more. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Drop table and register changeset src/main/resources/db/changelog/changesets/changelog_20261029T100000Z.xml, src/main/resources/db/changelog/db.changelog-master.yaml |
The new changeset drops the root_network_node_info_modifications_to_exclude table. The master changelog includes the new changeset and changelog_20261027T145550Z.xml. |
Suggested reviewers: ayolab
Priority:
Merge Risk: 
8dd81
-
The change removes the obsolete exclusions table in the established migration order. No actionable issue was found; it is ready to merge subject to normal checks.
Pre-merge checks: 
-
Check name Status Explanation Description check The description explains why the table can be removed and references the related migration changes. It is directly related to the changeset. Title check The title clearly and concisely states the main change: dropping the table of modifications to exclude. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…ons-to-exclude-table Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com> # Conflicts: # src/main/resources/db/changelog/db.changelog-master.yaml
|
The modifications a root network used to leave out were replaced by applicabilities per root network tag, made explicit in network-modification-server by gridsuite/network-modification-server#932. #1100 dropped the foreign key of
root_network_node_info_modifications_to_excludeand kept its rows in case the migration had to be replayed; this drops the table.