Implement encoding_name() to get the encoding name#17
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Groonga-context-aware encoding lookup so Python str values can be encoded according to the current grn_ctx encoding when writing text into Groonga objects.
Changes:
- Add
grnpy_ctx_get_encoding(grn_ctx*)C helper to exposeGRN_CTX_GET_ENCODING(ctx)to Cython. - Implement
Context.encoding_name()in Cython to map Groongagrn_encodingvalues to Python codec names. - Use
context.encoding_name()when encodingstrvalues inObject._set_value().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| grnpy/object.pyx | Encodes str values using the context’s encoding name instead of the default str.encode() behavior. |
| grnpy/grnpy_ctx.h | Declares a new helper to retrieve the current grn_ctx encoding. |
| grnpy/grnpy_ctx.c | Implements the new helper via GRN_CTX_GET_ENCODING(ctx). |
| grnpy/context.pyx | Adds Context.encoding_name() to translate Groonga encodings into Python codec names. |
| grnpy/context.pxd | Exposes the new encoding_name() Cython method to other Cython modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.