feat: declare agones command permission#59
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 610635f9a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lusu007
force-pushed
the
feat/use-grounds-dependencies-bom
branch
from
610635f to
7c469b2
Compare
lusu007
changed the title
lusu007
force-pushed
the
feat/use-grounds-dependencies-bom
branch
from
7c469b2 to
749679e
Compare
lusu007
changed the title
lusu007
force-pushed
the
feat/use-grounds-dependencies-bom
branch
from
749679e to
16128ee
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Declares the Velocity /agones command permission in the plugin permission manifest and adds focused tests around the command gate.
Permission key:
grounds.command.agonesManifest resource:
META-INF/grounds/permissions.jsonThe command already used the correct
grounds.command.<commandName>shape; this PR now makes that permission discoverable for the permissions catalog and locks the behavior with tests.Type of Change
Related Issues
Testing
Verified with:
./gradlew :velocity:test --tests gg.grounds.command.AgonesCommandTest --tests gg.grounds.command.AgonesPermissionManifestTest./gradlew test./gradlew spotlessApply./gradlew buildChecklist