protoc-gen-rust-grpc: fix macos universal build#2662
Closed
dfawley wants to merge 1 commit into
Closed
Conversation
ejona86
reviewed
May 29, 2026
| -DBUILD_PLUGIN=ON \ | ||
| -DRUST_GRPC_VERSION="$VERSION_FROM_TAG" \ | ||
| ${{ matrix.cmake_flags }} | ||
| "${{ matrix.cmake_flags }}" |
Member
There was a problem hiding this comment.
Wouldn't this make -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=s390x -DCMAKE_C_COMPILER=s390x-linux-gnu-gcc -DCMAKE_CXX_COMPILER=s390x-linux-gnu-g++ be a single argument. That is not going to do what you want. I don't know if Github allows us to use an array here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake flags were not properly quoted, so when the mac universal build used a semicolon in them, it was treated as the end of the command by bash. This fixes that by quoting the flags.