Update vue-language-tools monorepo to v3#13
Conversation
9f3272d to
f6c7fba
Compare
|
We're stuck on v2 because v3 requires the LSP client to forward tsserver/request messages to vtsls, which Claude Code doesn't implement (Piebald-AI/claude-code-lsps#43). |
076a202 to
07d0b46
Compare
07d0b46 to
dc6f927
Compare
📝 WalkthroughWalkthroughThe PR updates the ChangesDependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 9: package.json currently pins "`@vue/language-server`" to "3.3.3" which is
incompatible with our LSP client because pnpmfile.cjs documents that v3 requires
forwarding tsserver/request to vtsls; either revert this dependency to a v2.x
pin (match the previous 2.x semver) or add a gate that only installs/uses
"`@vue/language-server`" v3 when the LSP client implements the tsserver/request ->
vtsls forwarding; update package.json to the v2 pin or add logic around
installation/resolution (referenced symbols: "`@vue/language-server`", version
"3.3.3", pnpmfile.cjs, tsserver/request, vtsls) so the repo never installs v3
unless the forwarding support is present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2b2556e1-5099-49e4-91a6-0f96e839cd1a
📒 Files selected for processing (1)
package.json
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
package.json
📄 CodeRabbit inference engine (AGENTS.md)
Global pnpm package versions must be centralized in
package.jsonat the repo root; do not hardcode versions in scripts or templates
Files:
package.json
| "@readonly-mcp/core": "github:readonly-mcp/core#1ff05ccedbe3a589decdbd67e73f98a5884f3286", | ||
| "@vtsls/language-server": "0.3.0", | ||
| "@vue/language-server": "2.2.12", | ||
| "@vue/language-server": "3.3.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: confirm documented v3 incompatibility assumptions still exist.
set -euo pipefail
echo "== Check repo note about Vue LS v3 forwarding requirement =="
rg -n -C2 'stuck on v2|tsserver/request|vtsls|`@vue/language-server` 2.x|`@vue/language-server` 3' pnpmfile.cjs || true
echo
echo "== Check current pinned version in package.json =="
rg -n '"`@vue/language-server`"' package.json
echo
echo "== Search for any explicit forwarding implementation hints in repo =="
rg -n -C2 'tsserver/request|vtsls|forward.*request|language-server.*forward' || trueRepository: gtbuchanan/dotfiles
Length of output: 3648
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n '"`@vue/language-server`"\s*:\s*"[0-9.]+"' -S . || true
rg -n '`@vue/language-server`' pnpm-lock.yaml package.json 2>/dev/null || true
ls -laRepository: gtbuchanan/dotfiles
Length of output: 1267
Gate or revert the @vue/language-server v3.3.3 bump to avoid the documented Claude Code LSP incompatibility
package.json pins @vue/language-server to 3.3.3, but pnpmfile.cjs explicitly documents that @vue/language-server v3 requires the LSP client to forward tsserver/request to vtsls, which Claude Code doesn’t implement. No forwarding implementation (or 2.x fallback pin) exists elsewhere in this repo.
Revert the bump (keep a v2 pin) or gate it on client support for the required forwarding path.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 9, package.json currently pins "`@vue/language-server`"
to "3.3.3" which is incompatible with our LSP client because pnpmfile.cjs
documents that v3 requires forwarding tsserver/request to vtsls; either revert
this dependency to a v2.x pin (match the previous 2.x semver) or add a gate that
only installs/uses "`@vue/language-server`" v3 when the LSP client implements the
tsserver/request -> vtsls forwarding; update package.json to the v2 pin or add
logic around installation/resolution (referenced symbols:
"`@vue/language-server`", version "3.3.3", pnpmfile.cjs, tsserver/request, vtsls)
so the repo never installs v3 unless the forwarding support is present.
This PR contains the following updates:
2.2.12→3.3.3Release Notes
vuejs/language-tools (@vue/language-server)
v3.3.3Compare Source
vscode
workspace
auto-versionworkflow to prevent injection (#6074) - Thanks to @arpitjain099!v3.3.2Compare Source
language-core
v-forsources (#6067) - Thanks to @kkesidis!v-bindshorthand identifier skipping with interpolation - Thanks to @KazariEX!vscode
v3.3.1Compare Source
language-core
language-service
typescript-plugin
vscode
v3.3.0Compare Source
language-core
v-ifbranch fragments when collecting single root nodes - Thanks to @KazariEX!SfcAPIs toIR- Thanks to @KazariEX!language-service
html.customData(#5910) - Thanks to @Bomberus!=""only for plain boolean props completion edits - Thanks to @KazariEX!typescript-plugin
vscode
extraFileExtensionsin tsserverconfigurerequest payload (#6048) - Thanks to @KazariEX!v3.2.9Compare Source
language-core
vscode
workspace
v3.2.8Compare Source
language-core
GlobalComponents(#6026) - Thanks to @Gehbt!language-service
@importnavigation (#6033) - Thanks to @KazariEX!typescript-plugin
vscode
reactive-vscodeto v1.0.1 (#6019) - Thanks to @kermanx!v3.2.7Compare Source
component-meta
workspace
v3.2.6Compare Source
language-core
$slotstype in template correctly withdefineSlots(#5984) - Thanks to @KazariEX!v-for(#5987) - Thanks to @ascott18!vscode
v3.2.5Compare Source
language-core
language-service
language-plugin-pug
workspace
pluginsoption - Thanks to @KazariEX!v3.2.4Compare Source
language-core
ctx.configand support type annotation via generics (#5944) - Thanks to @KazariEX!workspace
v3.2.3Compare Source
language-core
defineModelbreaking ast inlang="js"(#5935) - Thanks to @KazariEX!typescript-plugin
vscode
<style>and<script>tags (#5925) - Thanks to @serkodev!v3.2.2Compare Source
language-core
language-plugin-pug
language-service
=""for boolean props completion edits (#5888) - Thanks to @KazariEX!typescript-plugin
v3.2.1Compare Source
language-core
v-for(#5896) - Thanks to @serkodev!component-meta
optionisfalse(#5891) - Thanks to @KazariEX!component-type-helpers
language-service
:xxx(shorthand) when no prefix is typed, instead of bothxxxand:xxxv3.2.0Compare Source
vscode
fast-diffwith custom character-by-character alignment algorithm (#5849) (#5851)language-service
component-meta
tagsto slots and exposed (#5862) - Thanks to @aj-dev!exposed(#5868) - Thanks to @aj-dev!typescript-plugin
ts.CompletionEntryData(#5869) - Thanks to @KazariEX!language-core
v-fortype inference (#5836)v-forkey type withObject.keys(#5837) - Thanks to @serkodev!<!-- @​strictTemplates -->magic comment (#5845)<script src="">(#5838)createIfBranch(#5844) - Thanks to @serkodev!component-type-helpers
ComponentTypehelperworkspace
v3.1.8Compare Source
Features
<script>and<style>tag (#5830) - Thanks to @serkodev!Bug Fixes
preferencesandformatOptionsin tsserver (#5829)Other Changes
v3.1.7Compare Source
Features
scriptId(#5811) - Thanks to @serkodev!Bug Fixes
Identifier.textproperty (#5810)__VLS_SlotsgenerationOther Changes
v3.1.6Compare Source
Features
<script setup>(#5805)Bug Fixes
createParsedCommandLineByJsonparsed incorrect options since v3.1.5 (#5768 (comment))vue.server.pathcompatible with Windows (#5772)getVIfNodeto supportv-else-ifdirectives (#5765) - Thanks to @serkodev!{}instead of its string value forstyle="..."(#5781) - Thanks to @KazariEX!v-bind="$attrs"loses navigation wheninferTemplateDollarAttrsis disabled (#5783)const props =completion in StringLiteral (#5786)$eltype for generic components usinginferComponentDollarEl(#5794)<script>content generates before<script setup>(#5795)bypassDefineComponenthack for better JS support (#4876) (#5379)Prettify<T>caused generic props gets inferred asunknown(#5667) - Thanks to @so1ve!<as operator in SFC scripts (#5801) - Thanks to @serkodev!isTypeScriptDocumentin VSCode fortypescript.preferences.autoImportSpecifierExcludeRegexesconfig support (#5364)vaporattr (#5496)Performance
:class- Thanks to @KazariEX!Other Changes
debuggerfrom virtual code for tsslint compatibilityref="xxx"rawTypeand__internal__.tsLs(#5808)createResolveModuleName(volarjs/volar.js#293) (#5644) - Thanks to @serkodev!v3.1.5Compare Source
Features
serverInfoto initialized result (#5767) - Thanks to @kada49!Bug Fixes
template(#5755) - Thanks to @serkodev and @KazariEX!vue-tsccrash during single file checks (#5768) - Thanks to @KazariEX!Performance
v3.1.4Compare Source
Bug Fixes
@ts-expect-errordirective on components with loose props checks (#5750) - Thanks to @serkodev and @KazariEX!v-else(#5753) - Thanks to @serkodev and @KazariEX!Other Changes
v3.1.3Compare Source
Features
<template>(#5734) - Thanks to @KazariEX!Bug Fixes
lang="html"(#5728) - Thanks to @serkodev!Other Changes
v3.1.2Compare Source
Bug Fixes
propTypeshas no elements (#5704) - Thanks to @so1ve!Other Changes
vue-tscbroken link to example boilerplate inREADME.md(#5721) - Thanks to @heyakyra!v3.1.1Compare Source
Features
--tsdkcommand line arg (#5691)Bug Fixes
RefbyRefSymbolproperty (#5687) - Thanks to @KazariEX!__vue__in project instead of program (#5690)$scopedSlotssupport for Vue 2__VLS_export(#5696) - Thanks to @KazariEX!Other Changes
writeGlobalTypeswithout side effectsv3.1.0Compare Source
Performance
Other Changes
v3.0.11Compare Source
v3.0.10Compare Source
Bug Fixes
__vue__in project instead of program (#5690)v3.0.9Compare Source
Features
--tsdkcommand line arg (#5691)v3.0.8Compare Source
Features
vue.server.pathsetting (#5647)Bug Fixes
VueVirtualCodein constructor (#5635) - Thanks to @KazariEX!typescriptServerPluginlanguages without FS hackfilescheme files (#5653) - Thanks to @KazariEX!Performance
Other Changes
v3.0.7Compare Source
Bug Fixes
Other Changes
@typescript-eslint/no-unnecessary-condition(#5630)v3.0.6Compare Source
Bug Fixes
:classexpression with parens - Thanks to @KazariEX!targetoption (#5583) - Thanks to @gxres042!vue-component-type-helperstolib/helpers(#5600)configFileNamedefault value (#5606)js/ts.hover.maximumLengthandtypescript.experimental.expandableHover(#5577)Other Changes
excludeconfig suggestion from global types error message (#5579) - Thanks to @Ciallo-Chiakivue-component-type-helpersto current version (#5589) - Thanks to @kingyue737!v3.0.5Compare Source
Features
compileSFCStyleto provide style related infomation (#5548) - Thanks to @KazariEX!v-for(#5553) - Thanks to @KazariEX!Bug Fixes
modelModifiersfor explicitly declared default model name (#5558) - Thanks to @KazariEX!.valueinsertionclassscope fallback forcomponentsemantic tokens (#5559) - Thanks to @KazariEX!globalTypesPathfor FS filesrestartExtensionHostOther Changes
v3.0.4Compare Source
Features
Bug Fixes
skipTemplateCodegenwhen exposing$slots- Thanks to @KazariEX!Other Changes
checkUnknownEventsandcheckUnknownComponentsin sfc (#5537) - Thanks to @KazariEX!v3.0.3Compare Source
Bug Fixes
node_modulesbased on file's directory (#5525) - Thanks to @KazariEX!Other Changes
v3.0.2Compare Source
Features
globalTypesPathoption for non-npm like environment (#5505) - Thanks to @KazariEX!Bug Fixes
/or)- Thanks to @KazariEX!colorizedBracketPairsconfig for plaintext<component>withoutisprop as normal component - Thanks to @KazariEX!@vue/typescript-pluginlast (#5483)namevalue of<slot>- Thanks to @KazariEX!allowJsto reactivity analyze host - Thanks to @KazariEX!mdfor markdown (#5497) - Thanks to @KazariEX!modulefrom template completion - Thanks to @KazariEX!Other Changes
minimatchtopicomatch(#5499) - Thanks to @KazariEX!.d.${ext}.tsfile exists (volarjs/volar.js#277)v3.0.1Compare Source
Bug Fixes
__vue__in project instead of program (#5690)v3.0.0Compare Source
Features
strictVModeloption (#5229) - Thanks to @KazariEX!v-onsyntax (#5275) - Thanks to @KazariEX!Configuration
📅 Schedule: (in timezone America/Chicago)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.