Set 'storybook.thegulocal.com' as an allowed host in storybook#15733
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
approved these changes
Apr 21, 2026
|
Seen on PROD (merged by @abeddow91 8 minutes and 30 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
storybook.thegulocal.comas an allowed host in storybookcore.allowedHostsconfig.It also extends the list of make commands to include
storybook-proxy. Running this will open storybook on the storybook.thegulocal.com domain by default, reducing some friction whilst devloping of having to remember the domain. This has been added as a separate command rather than extending the currentstorybookcommand so that users are not forced to use nginx mappings.Why?
Storybook's dev server validates the
Hostheader on incoming requests and rejects any host not explicitly allowed, returning a 403. When accessing Storybook via the local reverse proxy at storybook.thegulocal.com (rather than localhost:4002 directly), requests were being rejected with an invalid host error.Adding the proxy domain to allowedHosts allows Storybook to be accessed through the nginx reverse proxy, which is necessary for developing components, such as videos with subtitles, that require a specific origin to satisfy cross-origin policies.
Screenshots