Consistently sets self hosted video tracking ID#15739
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
approved these changes
Apr 22, 2026
Contributor
abeddow91
left a comment
abeddow91
left a comment
There was a problem hiding this comment.
Great! Thanks for improving consistency across the platform
domlander
approved these changes
Apr 22, 2026
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This change sets the
dataLinkNamesetting thevideoStyleto lower case. This is consistent with how media events are sent:dotcom-rendering/dotcom-rendering/src/components/SelfHostedVideo.island.tsx
Line 395 in 9ae227c
Why?
Event IDs are currently capitalised inconsistently:
Click events:
Media:
{"id":"gu-video-loop-11ca062f-a073-4ada-8d15-1cba8bc87ae6","eventType":"video:content:play"}It's questionable whether we need these click events, but they shouldn't cause any harm. Having a consistent ID will make life easier downstream.