Open
Conversation
tonytw1
changed the title
andrew-nowak
added
the
maintenance
tonytw1
force-pushed
the
eelpie/dynamo-store-tests-20260406
branch
from
c2b0edd to
bc7c73d
Compare
Contributor
Author
|
Rebased picking up recent childMetaData field on MediaUsage. |
…ncies rather than all of CommonConfig.
For simpler test setup ImageCollectionsStore takes specific dependencies rather than all of CommonConfig.
…ndencies rather than all of CommonConfig. Change the constructor parameters of EditsStore, SyndicationStore and UsageTable to take Dynamo client(s) and table name only. # Conflicts: # usage/app/UsageComponents.scala
…rather than all of CommonConfig.
tonytw1
force-pushed
the
eelpie/dynamo-store-tests-20260406
branch
from
d3bca08 to
2998e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Provides some basic tests of the Dynamo backed Stores.
Follows the test container pattern used in the Elastic tests.
For ease of testing, refactor the constructors of the Stores to accept the specific required dependencies rather than
CommonConfig.This sets up for the rewrite of
UsageTableinto sdk v2 format.How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?