Open
Conversation
andrew-nowak
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the Cloudfront SDK and usage.
We need to migrate from v1 to v2 of all the SDK modules. Our only usage of the Cloudfront SDK is to sign thumbnail URLs. However we don't (and possibly never have) enforced verification of the signatures.
I've had a quick poke and it doesn't appear straightforward to start enforcing this, and since we've not done it in the past and it doesn't appear we're needing to do it soon, I think it might make most sense to just tear it out.
I'll leave a card suggesting reviewing and implementing signatures & verification, with a link to this PR which can serve as a starting point for implementing it properly with the new SDK if we decide to come back to it.
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?