Skip to content

⚡ Bolt: Vectorize BasicEstimator prediction#33

Open
guesswh0 wants to merge 1 commit into
masterfrom
bolt-vectorize-estimator-1206037168485573281
Open

⚡ Bolt: Vectorize BasicEstimator prediction#33
guesswh0 wants to merge 1 commit into
masterfrom
bolt-vectorize-estimator-1206037168485573281

Conversation

@guesswh0
Copy link
Copy Markdown
Owner

💡 What: Replaced the loop-based nearest neighbor search in BasicEstimator.predict with a fully vectorized implementation using NumPy matrix operations and the squared Euclidean distance expansion formula. Updated fit to pre-calculate squared norms of fitted embeddings.
🎯 Why: The original implementation used a Python loop to calculate distances for each input embedding one by one, which is inefficient for large batches of embeddings or large fitted datasets.
📊 Impact: Achieved a ~10-12x speedup for batches of 500 embeddings against 2000 fitted embeddings (from ~0.25s down to ~0.02s).
🔬 Measurement: Verified using a custom benchmark script (checking both speed and result consistency) and ensured existing tests pass.


PR created automatically by Jules for task 1206037168485573281 started by @guesswh0

Vectorize BasicEstimator.predict using NumPy matrix operations and pre-calculated norms for significantly faster nearest-neighbor search. Includes handling for empty input and backward compatibility for loaded models.

Co-authored-by: guesswh0 <10531675+guesswh0@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant