Skip to content

⚡ Bolt: vectorized BasicEstimator.predict and find_faces#34

Open
guesswh0 wants to merge 1 commit into
masterfrom
bolt-vectorization-8092146456918900583
Open

⚡ Bolt: vectorized BasicEstimator.predict and find_faces#34
guesswh0 wants to merge 1 commit into
masterfrom
bolt-vectorization-8092146456918900583

Conversation

@guesswh0
Copy link
Copy Markdown
Owner

💡 What: Vectorized BasicEstimator.predict using the L2 distance expansion formula and optimized BasicEstimator.fit with pre-calculated norms. Also vectorized bounding box area calculation and fixed a metadata slicing bug in FaceEngine.find_faces.

🎯 Why: BasicEstimator.predict used a loop with np.linalg.norm, which is inefficient for large batches. find_faces used a list comprehension for area calculation and had a bug that misaligned extra metadata when limiting detections.

📊 Impact: Achieved ~13x speedup in BasicEstimator.predict (from ~0.25s to ~0.018s for a batch of 500 queries vs 2000 targets). Improved efficiency and correctness in FaceEngine.find_faces.

🔬 Measurement: Verified with benchmark scripts (baseline vs opt) and mock detector script for find_faces. All existing unit tests pass.


PR created automatically by Jules for task 8092146456918900583 started by @guesswh0

- Vectorized BasicEstimator.predict using the L2 expansion formula.
- Optimized BasicEstimator.fit by pre-calculating squared norms.
- Vectorized FaceEngine.find_faces bounding box area calculation.
- Fixed extra metadata slicing bug in FaceEngine.find_faces.
- Added guard for empty embeddings in predict.

Co-authored-by: guesswh0 <10531675+guesswh0@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant