⚡ Bolt: optimize estimator prediction and face detection#40
Conversation
- Vectorize BasicEstimator.predict using squared distance expansion formula - Pre-calculate fitted embedding norms for faster inference - Vectorize bounding box area calculation in FaceEngine.find_faces - Fix metadata indexing bug in FaceEngine.find_faces when limit is applied - Add backward compatibility for loaded models missing pre-calculated norms - Ensure numerical stability with np.maximum(dists_sq, 0) Co-authored-by: guesswh0 <10531675+guesswh0@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
BasicEstimator.predictusing the squared distance expansion formula.BasicEstimator.fitand ensured backward compatibility inload.FaceEngine.find_faces.FaceEngine.find_faceswhereextrametadata was incorrectly indexed whenlimitwas applied (it was taking a single element instead of slicing/reordering).🎯 Why:
predictimplementation used an explicit Python loop over input embeddings, which was a significant bottleneck for batch processing.find_facesused a list comprehension for area calculation which can be vectorized for better performance.limitlogic infind_faceswas broken, causing metadata misalignment and potential crashes whenextrafields were accessed.📊 Impact:
BasicEstimator.predict(measured from ~0.22s to ~0.035s for 500 query embeddings against 2000 fitted embeddings).🔬 Measurement:
find_facesis now correct via mocked detector tests.PR created automatically by Jules for task 793044226827246022 started by @guesswh0