Fix tag error for workflow segments files#5304
Merged
GarethCabournDavies merged 1 commit intomasterfrom Apr 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an offline-search workflow bug when a segments source is configured as a direct file, by using the correct tag-aware config accessor for a list of tags.
Changes:
- Replace
cp.get_opt_tag(...)(single-tag API) withcp.get_opt_tags(...)(multi-tag API) when resolving a*-fileoption underworkflow-segments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spxiwh
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error if you try to use a segment file directly, caused as this call expects a single tag rather than a list
Standard information about the request
This is a: bug fix
This change affects: the offline search
This change: follows style guidelines (See e.g. PEP8)
Motivation
🐛