Skip to content

Fix tag error for workflow segments files#5304

Merged
GarethCabournDavies merged 1 commit intomasterfrom
segment_file_tags
Apr 2, 2026
Merged

Fix tag error for workflow segments files#5304
GarethCabournDavies merged 1 commit intomasterfrom
segment_file_tags

Conversation

@GarethCabournDavies
Copy link
Copy Markdown
Contributor

There is an error if you try to use a segment file directly, caused as this call expects a single tag rather than a list

Standard information about the request

This is a: bug fix

This change affects: the offline search

This change: follows style guidelines (See e.g. PEP8)

Motivation

🐛

  • The author of this pull request confirms they will adhere to the code of conduct

Copilot AI review requested due to automatic review settings March 18, 2026 16:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an offline-search workflow bug when a segments source is configured as a direct file, by using the correct tag-aware config accessor for a list of tags.

Changes:

  • Replace cp.get_opt_tag(...) (single-tag API) with cp.get_opt_tags(...) (multi-tag API) when resolving a *-file option under workflow-segments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GarethCabournDavies GarethCabournDavies merged commit 1a1745c into master Apr 2, 2026
54 of 59 checks passed
@GarethCabournDavies GarethCabournDavies deleted the segment_file_tags branch April 2, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug BUG - FIX ASAP offline search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants