Fix C string memory leak in EXIF tag helpers#484
Open
kkato wants to merge 1 commit into
Open
Conversation
vipsExifStringTag and vipsExifIntTag allocated a C string via C.CString(tag) but never freed it, leaking on the C heap on every call. Metadata() reads ~50 EXIF fields through these helpers, so each processed image leaks ~50 small allocations, growing the C heap unbounded over time. Free the allocation with defer C.free, matching the pattern already used by vipsWindowSize, vipsWatermark and vipsTransformICC. Fixes h2non#483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
vipsExifStringTagandvipsExifIntTagallocate a C string withC.CString(tag)but never free it, so every call leaks it on the C heap.C.CString(tag)is never freed invipsExifStringTag/vipsExifIntTag(C heap memory leak) #483What
Free the
C.CStringallocation withdefer C.free, like the other functions in this file do.