make video controls appear on hover or focus#1043
Open
fstorr wants to merge 3 commits into
Open
Conversation
jaronheard
reviewed
Oct 7, 2019
jaronheard
left a comment
jaronheard
left a comment
Contributor
There was a problem hiding this comment.
I tested this PR and have the following notes:
iPhone Safari works great.
Desktop browsers showing controls overlay feels a little heavy handed. Maybe could show controls on click? Not sure how to address, or if it should be left as is.
With "Prefers reduced motion" on, Chrome doesn't show the poster frame
|
I was running into an issue with being able to show a poster for this PR on certain browsers. An easy solution would be to who the white screen at the end of the video rather than the beginning, so we don't even have to implement the poster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.