fix out-of-bounds channel index in read_big_endian_row#9219
Open
Nashit-h wants to merge 1 commit into
Open
Conversation
alexreinking
approved these changes
Jul 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9219 +/- ##
=======================================
Coverage ? 69.80%
=======================================
Files ? 255
Lines ? 78580
Branches ? 18790
=======================================
Hits ? 54849
Misses ? 18169
Partials ? 5562 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_big_endian_row writes each decoded value to channel c + cmin, but c already runs from cmin to cmax, so the channel index lands at 2*cmin..cmin+cmax and any destination buffer with a nonzero channel min gets written past its channel bounds and out of the allocation. The write sibling write_big_endian_row indexes plain c, so this drops the extra offset to match. The added test feeds the row reader a channel-offset buffer and checks the values land in the right channels.