Use private types in the interface#2
Open
yallop wants to merge 3 commits into
Open
Conversation
|
I think this is a great addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present,
Uint8.tandUint16.tare both exposed as equal toint. Consequently, it's easy to build invalid values of those types:This PR marks the types
Uint8.tandUint16.tprivatein the interface so only the functions in the interface, which maintain validity, can be used to create values of those types. It's still easy and free to convert from aUint8.tor aUint16.tto an int by coercing: