refactor: simplify membership checks#345
Open
tenthirtyam wants to merge 1 commit into
Open
Conversation
Replace manual search loops with `slices.Contains`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
refactor/simplify-membership-checks
branch
from
July 25, 2026 17:56
989bd57 to
a9d4945
Compare
Author
|
Hi @tanmay-hc, The CI failure was a missing import. Can you rerun the CI when time permits? TY! Ryan Johnson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace manual search loops with
slices.Contains.Resolved Issues
For comparable element types,
slices.Containsperforms the same check in one call.Rollback Plan
Revert commit.
Changes to Security Controls
None.