Skip to content

refactor: use maps.Copy for map merging#349

Open
tenthirtyam wants to merge 1 commit into
hashicorp:mainfrom
tenthirtyam:refactor/map-merging
Open

refactor: use maps.Copy for map merging#349
tenthirtyam wants to merge 1 commit into
hashicorp:mainfrom
tenthirtyam:refactor/map-merging

Conversation

@tenthirtyam

Copy link
Copy Markdown

Description

Replaced manual map-copy loops with the standard library helper to express intent directly and reduce boilerplate.

Resolved Issues

Loops that copy a map or collect its keys or values and can be replaced with maps.Copy, maps.Keys, or maps.Values. These helpers express the intent directly and reduce boilerplate code.

Rollback Plan

Revert commit.

Changes to Security Controls

None.

Replace manual map-copy loops with the standard library helper to express intent directly and reduce boilerplate.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam
tenthirtyam requested a review from a team as a code owner July 24, 2026 04:14
@tenthirtyam

Copy link
Copy Markdown
Author

Hi @tanmay-hc,

The CI failure appears to have been a rate limiting issue from the ubuntu runner.

It may pass on a rerun.

Node 20 is being deprecated. This workflow is running with Node 24 by default. If you need to temporarily use Node 20, you can set the ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true environment variable. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Run bufbuild/buf-setup-action@a47c93e0b1648d5651a065437926377d060baa99
Warning: No github_token supplied, API requests will be subject to stricter rate limiting
Setting up buf version "1.50.0"
Resolving the download URL for the current platform...
Error: API rate limit exceeded for 52.156.141.240. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) - https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting

Ryan Johnson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant