-
Notifications
You must be signed in to change notification settings - Fork 122
BE-474: HashQL: Take into account terminator target eligibility in execution backend placement #8587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bm/be-455-hashql-create-evaluation-target-coordinator
Are you sure you want to change the base?
BE-474: HashQL: Take into account terminator target eligibility in execution backend placement #8587
Changes from all commits
4570ff5
b0df31a
bafd1f4
0043039
fb84a39
3b0d31e
ba4eca6
8480ac3
22e7db9
a2dcffd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| skip = true | ||
| suite = "eval/orchestrator" | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orchestrator UI tests skipped with updated expected outputs
Medium Severity
A new
.spec.tomlwithskip = trueis added for the orchestrator UI test suite, whilefilter-false.stdoutandsimple-read.stdoutare simultaneously updated with significant behavioral changes (filter rows no longer received, target changed frominterpretertopostgres, new continuation lines). Because the tests are skipped, these expected-output updates are never actually verified against the real runtime output. If the actual behavior differs from the updated.stdoutfiles, the discrepancy will go undetected.Additional Locations (2)
libs/@local/hashql/eval/tests/ui/orchestrator/jsonc/filter-false.stdout#L1-L3libs/@local/hashql/eval/tests/ui/orchestrator/jsonc/simple-read.stdout#L1-L38Reviewed by Cursor Bugbot for commit a2dcffd. Configure here.