FE-706: Add design system components to Petrinaut#8720
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryMedium Risk Overview Updates Reviewed by Cursor Bugbot for commit 88f23bd. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 88f23bd. Configure here.
🤖 Augment PR SummarySummary: This PR migrates Petrinaut’s UI to the new Changes:
Technical Notes: DS 🤖 Was this summary useful? React with 👍 or 👎 |
kube
left a comment
There was a problem hiding this comment.
👍
Thanks!
Cool to know that these are all in the Design System now.
A little remark: name in <Icon name="" is a bit strange because you could think it is the HTML property, where it is actually the id of the icon (id wouldn't be better though)
Agree it's not perfect - I'll mull over it and see if I can come up with anything better, or if you think of anything let me know. I took a look at what some of the other major design systems use in case any of them have a better property name, but the only one which uses an api I've found so far is Atlaskit and they also use the term "name". |

🌟 What is the purpose of this PR?
Replaces all Buttons, IconButtons and Icons with DS components.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: