Skip to content

Make error impls public #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rschifflin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make error impls public #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2fb874
Make error impls public, so we can pull out syntax error line/cols pr…
rschifflin Feb 9, 2017
f80f21e
Use a method to extract syntax errors instead of changing visibility
rschifflin Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions json/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@ impl Error {
self
}
}

/// Extract the syntax error, if present
pub fn syntax_error(&self) -> Option<(ErrorCode, usize, usize)> {
let error_impl = self.err.as_ref();
match error_impl {
&ErrorImpl::Syntax(ref ec, line, col) => Some((ec.clone(), line, col)),
_ => None
}
}
}

impl Display for ErrorCode {
Expand Down