Refactor notice, info and debug functions#12024
Open
philderbeast wants to merge 11 commits into
Open
Conversation
philderbeast
force-pushed
the
refactor/notice-info-debug-messages
branch
from
July 1, 2026 18:39
19cf1e7 to
dffb1e2
Compare
Mikolaj
approved these changes
Jul 2, 2026
Collaborator
|
Sorry for nitpicking, but perhaps the PR title can be edited, like "Refactor notice, info and debug functions". I've been confused what it means until I looked inside. |
philderbeast
changed the title
philderbeast
force-pushed
the
refactor/notice-info-debug-messages
branch
2 times, most recently
from
July 5, 2026 12:36
e3d107c to
698924f
Compare
andreabedini
approved these changes
Jul 6, 2026
philderbeast
force-pushed
the
refactor/notice-info-debug-messages
branch
from
July 6, 2026 19:01
698924f to
1c2da84
Compare
- Rename logMsgNoWrap to logMsg
philderbeast
force-pushed
the
refactor/notice-info-debug-messages
branch
from
July 16, 2026 14:05
1c2da84 to
97dd468
Compare
Collaborator
Author
|
After rebasing, this approved pull request failed to compile1. I got it compiling again but then saw an opportunity to reduce duplication even more so I'm re-requesting reviews. The post-approval changes are in the last 3 commits. Footnotes
|
philderbeast
force-pushed
the
refactor/notice-info-debug-messages
branch
from
July 16, 2026 15:26
d30aa4d to
96fad8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
notice,infoanddebugand the matching*NoWrapfunctions to share a common implementation.Note
hFlush stdoutis always called but shouldn't that behFlush h? This is a separate issue, #11899.